Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine - Add the ability to enable / disable / archive (delete) a Workflow #381

Open
tlawrie opened this issue Mar 21, 2023 · 4 comments
Open
Assignees
Labels

Comments

@tlawrie
Copy link
Member

tlawrie commented Mar 21, 2023

Add the ability to Archive a Workflow which will move it from active to inactive status. All the other calls / endpoints need to be updated to only work with Active Workflows. I.e. you can only submit an Active Workflow

@tlawrie tlawrie converted this from a draft issue Mar 21, 2023
@tlawrie tlawrie self-assigned this Mar 21, 2023
@tlawrie tlawrie added the task label Mar 21, 2023
@tlawrie tlawrie moved this to To Do in Boomerang Flow Mar 21, 2023
@tlawrie tlawrie moved this from To Do to In Review in Boomerang Flow Mar 31, 2023
@tlawrie
Copy link
Member Author

tlawrie commented Mar 31, 2023

Implemented three status types on a Workflow: active, inactive, deleted.

This way a workflow can be disabled (inactive) and not be able to be executed.

@tlawrie tlawrie moved this from In Review to In Progress in Boomerang Flow Mar 31, 2023
@tlawrie
Copy link
Member Author

tlawrie commented Mar 31, 2023

I wonder if 'deleted' should be 'archived' or or whether deleted should just 'delete it' and therefore its not a status but i dont think we can do that as it would make it hard to view WorkflowRuns... hmm

@tlawrie
Copy link
Member Author

tlawrie commented Mar 31, 2023

@timrbula @amhudson @gchickma @marcusdroy thoughts please

@tlawrie tlawrie changed the title Engine - Add in Archive Workflow Ability and ensure other endpoints only work on Active Workflows Engine - Add the ability to enable / disable / archive (delete) a Workflow Mar 31, 2023
@amhudson
Copy link
Member

From the way I think about it, archived and inactive would mean an behave the same way. I don't think we want to actually delete any workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

2 participants