browsermt/marian-dev regression-test-failures #17
Comments
Click to expand
|
14c14
< Ago Leis, head of the Central Criminal Police Service, said the arrests were preceded by a probe into a year-and-a-half year-and-a-half investigation.
---
> Ago Leis, head of the Central Criminal Police Service, said the arrests were preceded by a year-and-a-half probe.
28c28
< For example, the latest court rulings, eight defendants separated from the so-called Dikayev Criminal Association criminal case who were ordered to pay BGN 80,000 for the proceeds of criminal damage, or the judgment of nine individuals, in 2006 that Igor Aleynikov established a criminal association aimed at the illegal trade in cigarettes and the committing of crimes related to human trafficking in East Virginia and the South in Estonia.
---
> For example, the latest court rulings, eight defendants separated from the so-called Dikayev Criminal Association criminal case, who were ordered to pay BGN 80,000 for the proceeds of criminal damage, or the judgment of nine individuals, in 2006 that Igor Aleynikov established a criminal association aimed at the illegal trade in cigarettes and the committing of crimes related to human trafficking in East Virginia and the South in Estonia.Why is this failing? |
This is a named parameter fail. |
Outputs are very different. 98 lines differ. Probably some gemm switch/feature to be enabled as a fix? |
Another parameter fail. |
|
|
Regression tests will incompatible with upstream, they use a toned down feature level intgemm (THey don't pass the output layer through intgemm, we do). As such you can't get the same numbers as upstream tests, even if you match the architecture. Some upstream gemm configurations are not available here. We use an architecture agnostic binary format, upstream has both architecture dependent and architecture agnostic. |
|
@kpu told me to compile what's happening, it's being done in this issue. What is a recommended fix so we can get rid of the build failure on all browsermt/* updates while keeping them separate? We can afford to keep separate regression tests if that's what it takes. I'm fairly certain I'm lacking enough context to get to the bottom of these test failures. |
|
Sooo basically, you need to rerun the test sets on the different machines (sse, avx2, avx512, avx512vnni), create gold standard references for those and then replace the old reference with those |
That sounds easy for places with diffs in expected vs outputs, something which I can do along setting up along with bergamot-translator tests. What of the remaining command/argument failures? (1, 3, and 5) |
|
Legacy batching, needs to be merged and fixed. Can you try the branch that I have proposed? |
|
@XapaJIaMnu I tested the change, it's working. Didn't have to change tests, so |
|
Technically the results between the legacy and non legacy batching should
be exactly the same. Since we are using dnnl, we only have the legacy code
path available
…On Sat, 6 Feb 2021, 22:51 Jerin Philip, ***@***.***> wrote:
@XapaJIaMnu <https://github.com/XapaJIaMnu> I tested the change, it's
working. Didn't have to change tests, so --use-legacy-batching is default
on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPO5VMA3HX3SJDEEYKOVW3S5XBVJANCNFSM4XBKLDPQ>
.
|
|
Current status on lofn: Some appear due to changes in the model archives where files have gone missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Status
Logs
Logs
http://vali.inf.ed.ac.uk/jenkins/job/browsermt-marian-regression-tests/7/console
Issue updated as I figure what exactly is failing.
Available Machines, vector instructions
The text was updated successfully, but these errors were encountered: