Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trader-Bugmark User Issue 2 #105

Open
NDamen opened this issue Jun 21, 2018 · 1 comment
Open

Trader-Bugmark User Issue 2 #105

NDamen opened this issue Jun 21, 2018 · 1 comment
Labels
TRADER trader exercise UI Simple / Comprehensible UI elements

Comments

@NDamen
Copy link

NDamen commented Jun 21, 2018

image
image

Issue Source: http://github.com/bugmark-trial/trader1/issues/276

Confusion:
a) How can the same person be a Funder and a Worker at the same time (Person ‘Si’) ?

b) The issue got resolved, but there is no resolve message in the issue messages on GitHub.

c) What does ‘value’ mean? I accepted 5 offers (and I believe I resold the ‘ > Si ‘ one, but I don’t remember that). There are a total of 9 offers for 6-15, thus the total value of the issue is 180. However, that is slightly confusing to me because when I am looking at my own overview, I don’t know/care about the total value, as I only care about what I put in myself.

Note: Although a solution was posted, this was after the maturation date, hence the funder got the payout.
Suggestion: Change the word ‘resolved’ into something more indicative of what happened, maybe a variation of ‘Unresolved: Funder payout’ and ‘Resolved: Worker payout’

@andyl andyl added the TRADER trader exercise label Jul 20, 2018
@andyl
Copy link
Contributor

andyl commented Jul 23, 2018

a) The exchange just tries to match buy offers on the fixed side to buy offers on the unfixed side. To match, we consider prices, volumes and maturation dates, but (normally) don't care about the identity of the user who offers. So yes, the exchange allows having the same person on both sides of a contract. But in most cases, the application would try to let a user cancel their own offer rather, and prevent taking their own offer.

b) In our newest exercise, the intern exercise, we're trying to clean up the resolution messaging.

c) Same as b) - we need to clean up this messaging. It's proven to be easier to create the trading mechanisms than to explain them. :-p

@andyl andyl closed this as completed Jul 23, 2018
@andyl andyl added the UI Simple / Comprehensible UI elements label Jul 23, 2018
@andyl andyl reopened this Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TRADER trader exercise UI Simple / Comprehensible UI elements
Projects
None yet
Development

No branches or pull requests

2 participants