Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when Folio deletion command times out #3

Open
mhucka opened this issue Jul 19, 2024 · 0 comments
Open

Bug when Folio deletion command times out #3

mhucka opened this issue Jul 19, 2024 · 0 comments

Comments

@mhucka
Copy link
Contributor

mhucka commented Jul 19, 2024

When Foliage issues a Folio command to delete a record, and the response times out, Folio may have completed the action, but Foliage thinks it failed (because of the timeout), so it retries it after a delay. Then, when Foliage retries the deletion command, it gets a 404 from Folio (because the record no longer exists) and thinks that that is a problem.

What Foliage should do instead is to take note of the fact that it is retrying a command due to a timeout, and if it gets a 404 in the retry, assume that the 404 means the first command actually went through instead of having failed.

This will require changes to delete_tab.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant