Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or update notebook 5_select_points.ipynb #19

Open
casadoj opened this issue Feb 14, 2024 · 1 comment
Open

Remove or update notebook 5_select_points.ipynb #19

casadoj opened this issue Feb 14, 2024 · 1 comment
Labels
question Further information is requested

Comments

@casadoj
Copy link
Owner

casadoj commented Feb 14, 2024

Since the selection of reporting points based on correlation was removed, does it make any sense to keep the notebook 5_select_points.ipynb and the parameters rho and upstream in the configuration file?

@casadoj casadoj added the question Further information is requested label Feb 16, 2024
@casadoj
Copy link
Owner Author

casadoj commented Feb 16, 2024

I have updated this notebook and make sure that it runs and it's coherent with the rest of the work flow.

  • I should add a condition that if rho is None, the selection is not done.
  • I need to add in notebook 6_skill.ipynb* a new way to load stations in case that rho is not None and based on the possible list of catchments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant