Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Check for update..." ... #52

Open
kowoba opened this issue May 11, 2023 · 3 comments
Open

"Check for update..." ... #52

kowoba opened this issue May 11, 2023 · 3 comments

Comments

@kowoba
Copy link

kowoba commented May 11, 2023

It gives this wonderful error message:

40536FA8:error:10000093:BIO routines:BIO_do_connect_retry:connection timeout:../../openssl/crypto/bio/bio_lib.c:969:

the reason is that Avalanche attempts to read https://www.unsatisfactorysoftware.co.uk/ver.php?f=avalanche directly, and it doesn't support proxy for https, it doesn't care about $http_proxy or $https_proxy variables.

A program that is supposed to be a small and efficient tool to open archives should not need to have its own networking and TLS handling code, so perhaps a better idea would be to leave http/https handling to dedicated tools that already do this very well, for example aget in the UHC-Tools package?

(Also I'd do the version string checks against release on aminet (http://aminet.net/util/arc/avalanche.readme) rather than a dedicated URL that would need to be "forever" maintained. Upon discovery of newer version, it seems naturally to offer to download the new version, and ...ehm... open the archive?)

@chris-y
Copy link
Owner

chris-y commented May 11, 2023

The code for this is tiny; it uses AmiSSL, I wouldn't have added it otherwise. It doesn't download and open yet, just checks.

I ignored the proxy on the (obviously incorrect) assumption that nobody would use an Amiga behind a proxy. Is there a standard way of setting it?

@kowoba
Copy link
Author

kowoba commented May 13, 2023

Standard way is to use the variables http_proxy and https_proxy, this is described for example in openssl documentation.

@chris-y
Copy link
Owner

chris-y commented May 15, 2023

OK, according to the docs it should use these without me doing anything special - except there's a mention of a callback which needs to be defined for https.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants