Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors on PG 9.4.26 and 9.5.25 #124

Open
hanefi opened this issue Sep 9, 2021 · 0 comments
Open

Build errors on PG 9.4.26 and 9.5.25 #124

hanefi opened this issue Sep 9, 2021 · 0 comments

Comments

@hanefi
Copy link
Member

hanefi commented Sep 9, 2021

Apparently I can not compile the project when I use locally built 9.4.26 and 9.5.25 PG versions. The errors are in a PG codebase and they error out my builds.

I am opening this issue to facilitate the discussion around this problem. The CI images can successfully build and test the project on mentioned PG versions.

bash$ make -sj8
In file included from /home/hanefi/.pgenv/pgsql-9.4.26/include/server/postgres.h:47,
                 from src/hll.c:16:
src/hll.c: In function 'hll_hash_varlena':
/home/hanefi/.pgenv/pgsql-9.4.26/include/server/c.h:633:2: error: operand of ?: changes signedness from 'char' to 'long unsigned int' due to unsignedness of other operand [-Werror=sign-compare]
  ((bool) ((! assert_enabled) || ! (condition) || \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     (ExceptionalCondition(CppAsString(condition), (errorType), \
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            __FILE__, __LINE__), 0)))
            ~~~~~~~~~~~~~~~~~~~~~~~~~
/home/hanefi/.pgenv/pgsql-9.4.26/include/server/postgres.h:104:3: note: in expansion of macro 'TrapMacro'
   TrapMacro(true, "unrecognized TOAST vartag"))
   ^~~~~~~~~
/home/hanefi/.pgenv/pgsql-9.4.26/include/server/postgres.h:288:55: note: in expansion of macro 'VARTAG_SIZE'
 #define VARSIZE_EXTERNAL(PTR)    (VARHDRSZ_EXTERNAL + VARTAG_SIZE(VARTAG_EXTERNAL(PTR)))
                                                       ^~~~~~~~~~~
/home/hanefi/.pgenv/pgsql-9.4.26/include/server/postgres.h:313:25: note: in expansion of macro 'VARSIZE_EXTERNAL'
  (VARATT_IS_1B_E(PTR) ? VARSIZE_EXTERNAL(PTR)-VARHDRSZ_EXTERNAL : \
                         ^~~~~~~~~~~~~~~~
src/hll.c:2990:15: note: in expansion of macro 'VARSIZE_ANY_EXHDR'
     int len = VARSIZE_ANY_EXHDR(vlap);
               ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [/home/hanefi/.pgenv/pgsql-9.4.26/lib/pgxs/src/makefiles/../../src/Makefile.global:780: src/hll.o] Error 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant