Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request- more compact display #11

Open
clandrew opened this issue Feb 19, 2020 · 4 comments
Open

Feature request- more compact display #11

clandrew opened this issue Feb 19, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@clandrew
Copy link
Owner

clandrew commented Feb 19, 2020

From e-mail:

"I was wondering if it's possible to modify the plugin to, instead of looking like this:

App Title
Band - Song
(Playing)
xx:xx elapsed

To change it to look like this:

App Title
Band
Song
xx:xx elapsed"

@clandrew clandrew added the enhancement New feature or request label Feb 26, 2020
@derekgates
Copy link
Contributor

I started working a PR for this.

Propose a checkbox to enable or disable the (status) line and replace with Artist/Title. I have this in place locally with the following mindset on how to change the output:

With (status):

Winamp
Artist - Title
(Status)
<Elapsed Time if enabled>

(status) disabled:

Winamp
Artist
Title
<Elapsed Time if enabled>

Current display to aid in understanding above pseudo code:
image

Issues I am running into are the wa_ipc.h not having a clean way to obtain Artist and Title separately, compared to the IPC_GET_PLAYING_TITLE macro being used.

I looked at the other header files in the WinAMP SDK and not having luck finding a way to obtain the Artist and Title separately.

@clandrew It seems to me that we need to obtain the Artist - Title string and regex or split the string on - and use the respective parts? Does that sound like a good approach?

(I accidentally had this comment in #9 ... sorry)

@clandrew
Copy link
Owner Author

clandrew commented Mar 1, 2020

re: general separating artist from title- There might be a way to get those from Winamp but it's hard to say. Speaking as a fan of Winamp I have to say its SDK is not very well documented. :/

Some things in the plug-in had to be figured out through experimentation since it wasn't clear at all from the plug-in header which is the one source of SDK documentation. Then there were forum posts but a lot of the contradicted each other. More recently i found out about a Discord for winamp devs (you're probably already in on this) so that could help me with these problems in the future.

For this particular issue I think it would be enough to just not show the "(Playing)". Especially with your change to disable the phone home to Discord when it's not playing anyway.

@derekgates
Copy link
Contributor

Ah, good note about the Winamp Discord, I wasn't on there yet. I've been trying to figure out what I can from the SDK (which is decently commented).

Would the approach of splitting on - (to get artist and title separated for this and other issues) be a good addition to:

For this particular issue I think it would be enough to just not show the "(Playing)". Especially with your change to disable the phone home to Discord when it's not playing anyway.

?

@papin97
Copy link

papin97 commented Jan 3, 2021

Is there any updates to this? I've been wanting this particular feature for months. I had to disable app icons so it will display more of title text. Or move playing status to big icon description so it will show on hovering the big icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants