Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Restrict deletion of previous comments to current user #10

Open
darend opened this issue Jan 9, 2019 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@darend
Copy link

darend commented Jan 9, 2019

GITHUB_DELETE_COMMENT_REGEX can be used to delete previous comments before posting the new one. The current implementation will delete matching comments regardless of who they were posted by. This can easily lead to false positives where someone happens to post comment that matches your regex (due to loose regex, or quoting, etc).

I do not see a use case to delete comments by others, and recommend restricting it to the user that the tool is running as.

@osterman
Copy link
Member

It seems like this can be fixed by reducing scope/permissions of the github access keys?

@osterman
Copy link
Member

Also, fwiw, I've seen other bots update existing comments rather than delete. That would be a safer implementation.

I think dependabot does this.

@osterman osterman added the enhancement New feature or request label Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants