Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect random generators #27

Closed
BeardOfDoom opened this issue Jan 19, 2020 · 4 comments
Closed

Incorrect random generators #27

BeardOfDoom opened this issue Jan 19, 2020 · 4 comments
Assignees
@BeardOfDoom
Labels
bug Something isn't working documentation Writing or fixing documentation

Comments

@BeardOfDoom
Copy link
Collaborator

I checked the random generators in Random.c and I think the random_unsignedIntInRange and the random_mpzInRange functions might be incorrect also all the functions are poorly documented in this file.

Further investigation required and documentation for the random generators.
@BeardOfDoom BeardOfDoom self-assigned this Jan 19, 2020
@BeardOfDoom BeardOfDoom added documentation Writing or fixing documentation invalid This doesn't seem right labels Jan 19, 2020
@battila7 battila7 added bug Something isn't working and removed invalid This doesn't seem right labels Jan 19, 2020
@battila7
Copy link
Collaborator

Nice catch! Replaced the invalid tag with bug, since this can very well be called a bug.

@battila7
Copy link
Collaborator

Documentation and reimplementation can be postponed until #21 is resolved.

@battila7 battila7 pinned this issue Jan 31, 2020
@battila7
Copy link
Collaborator

Change of plans: Implementation should be done prior to the resolution of #21. Fixed random generation should be part of v1

@BeardOfDoom BeardOfDoom mentioned this issue Feb 2, 2020
Merged
@battila7
Copy link
Collaborator

battila7 commented Feb 3, 2020

Closing as #34 is merged.

@battila7 battila7 closed this as completed Feb 3, 2020
@battila7 battila7 unpinned this issue Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeardOfDoom BeardOfDoom

Labels
bug Something isn't working documentation Writing or fixing documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BeardOfDoom @battila7