Skip to content
This repository has been archived by the owner on Oct 9, 2022. It is now read-only.

Feature Request: Do not use paths under $HOME as the default storage path #128

Open
wi1dcard opened this issue Dec 24, 2020 · 3 comments
Open
Assignees

Comments

@wi1dcard
Copy link
Member

As shadow currently creates multiple sub dir in $HOME, for example ~/.ethash and ~/.ethashproof, it increases the maintenance complexity. Users using docker and shadow will have to mount multiple volumes or mount $HOME as a volume which not only contains shadow data but also files like ~/.bash_history etc in the docker container. I don't think that's ideal.

For non-docker users, it is possible that they can run multiple shadow instances on a single VM. The default storage path will cause conflicts in that scenario.

My idea is that we can use the current working directory as the default storage path for shadow, which means if we launch shadow without additional options, it stores ethash and ethashproof in ./ethash and ./ethashproof.

It would be great as well if there's an option, such as --data-path or --storage-path that allows users changing the path specifically.

@wuminzhe
Copy link
Contributor

yes, it will be changed

@hackfisher
Copy link
Contributor

Is this fix in #133 ? @wuminzhe @xiaoch05

@xiaoch05
Copy link
Collaborator

Is this fix in #133 ? @wuminzhe @xiaoch05

Not yet

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants