Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R CMD check warning #202

Open
jrosen48 opened this issue Feb 15, 2024 · 2 comments
Open

R CMD check warning #202

jrosen48 opened this issue Feb 15, 2024 · 2 comments

Comments

@jrosen48
Copy link
Collaborator

@cjvanlissa, to my great shame, I am just now getting version 2.0.1 on CRAN. I am seeing this warning. I think it relates to the import of functions from tidySEM - agree or not?

❯ checking S3 generic/method consistency ... WARNING
  plot_bivariate:
    function(x, variables, sd, cors, rawdata, bw, alpha_range,
             return_list, ...)
  plot_bivariate.tidyLPA:
    function(x, variables, sd, cors, rawdata, bw, alpha_range,
             return_list)
  
  plot_bivariate:
    function(x, variables, sd, cors, rawdata, bw, alpha_range,
             return_list, ...)
  plot_bivariate.tidyProfile:
    function(x, variables, sd, cors, rawdata, bw, alpha_range,
             return_list)
  See section ‘Generic functions and methods’ in the ‘Writing R
  Extensions’ manual.
@cjvanlissa
Copy link
Collaborator

Dear Josh,
I don't think I "delivered" a ready-for-CRAN dev version; I did make some necessary changes and functional upgrades, but these all require checking. I can contribute to that after March 26th, but not now unfortunately. Just looking at the warning above, all you need to do is add ... to the arguments of the method plot_bivariate.tidyLPA and plot_bivariate.tidyProfle so that they have the same arguments as the generic.

@jrosen48
Copy link
Collaborator Author

Thanks. Maybe we can touch base after March 26th - I can definitely work on writing unit tests and doing additional documentation (edits to README and vignette and possibly examples/roxygen2 work). Are those the main tasks in your view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants