Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is this a plugin and not a pull request to ckan? #12

Closed
jbothma opened this issue Mar 14, 2018 · 5 comments
Closed

Why is this a plugin and not a pull request to ckan? #12

jbothma opened this issue Mar 14, 2018 · 5 comments

Comments

@jbothma
Copy link

jbothma commented Mar 14, 2018

This sounds important.

Why is this a plugin and not a pull request to CKAN?

@software-opal
Copy link
Contributor

software-opal commented Mar 14, 2018

Parts of this code are being pulled into CKAN, however some of the features are more opinionated than should be in CKAN. Additionally maintaining a plugin over the short term is significantly easier than a series of patches to core CKAN.

@jbothma
Copy link
Author

jbothma commented Mar 14, 2018 via email

@camfindlay
Copy link
Contributor

@jbothma see #2 We'd still be keen to take parts of this module and move into pull requests on core. We may need a hand to prep the pull requests and review them if you're up for helping out?

@camfindlay
Copy link
Contributor

I'm going to close this issue but feel free to pick the conversation back up in #2

@jbothma
Copy link
Author

jbothma commented Apr 12, 2018

Oh man I just totally looked past #2 when asking my question. Sorry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants