Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more defaults to reduce necessary config #27

Open
ThrawnCA opened this issue Feb 11, 2020 · 1 comment
Open

Use more defaults to reduce necessary config #27

ThrawnCA opened this issue Feb 11, 2020 · 1 comment
Assignees
@markstuart

Comments

@ThrawnCA
Copy link
Contributor

ThrawnCA commented Feb 11, 2020 •
edited
Loading

It would be possible to use more default settings in order to reduce the amount of configuration needed for this extension. For example:

  • Redis settings could default to localhost, port 6379, db 1, or perhaps reuse ckan.redis.url with an incremented db number.
  • CKANLoginThrottle and BeakerRedisAuth could be inserted by monkey-patching UsernamePasswordAuthenticator.
  • A default value for ckanext.security.domain could be extracted from ckan.site_url since that should use the externally visible domain.
@markstuart
Copy link
Contributor

These are good ideas @ThrawnCA, I'll see if we can get some budget to tidy this up a bit.

@markstuart markstuart self-assigned this Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markstuart markstuart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markstuart @ThrawnCA