Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the Difference FacilityLocation vs FacilitySMDGLocation ? #152

Open
cmsdroff opened this issue Apr 25, 2023 · 1 comment
Open

What's the Difference FacilityLocation vs FacilitySMDGLocation ? #152

cmsdroff opened this issue Apr 25, 2023 · 1 comment

Comments

@cmsdroff
Copy link
Contributor

The DCSA Facility entity identifies 2 facility types:

  • BIC
  • SMDG

Both of these are child codes of the UNLOCODE and based upon the UNLOCODE as the first 5 characters. For BIC and SMDG they then provide the 'extension' code to identify the facility. i.e. GBLIVJMDA (BIC) or DEHAMHHLA (SMDG)

The facilityLocation covers both BIC and SMDG by using the attribute to differentiate facilityCodeListProvider being set as either BIC or SMDG respectively.

The facilitySMDGLocation is a duplicate of the above with the UNLOCODE mandatory instead of optional (added later), and for both supported facility types in DCSA the UNLOCODE is mandatory, but everything else is the same, so why separate ?

This now leads to 2 places to add the SMDG code, giving an unnecessary choice and adding additional mapping logic.

I would suggest only having 1 i.e. facilityLocation and use the facilityCostListProvider to identify as this matches the model, struggle to see why this isn't sufficient?

Screenshot 2023-04-25 at 14 53 18

@HenrikHL
Copy link
Contributor

HenrikHL commented Aug 1, 2023

Hi @cmsdroff,
Sorry for the late reply :-(

The facilitySMDGLocation is a duplicate of the above with the UNLOCODE mandatory instead of optional (added later), and for both supported facility types in DCSA the UNLOCODE is mandatory, but everything else is the same, so why separate ?

This was a request from the Carriers as in some cases they do not want to have to specify the facilityCodeListProvider as being SMDG. This is specifically in OVS and JIT where only SMDG facility codes are needed. Prior to the facilitySMDGLocation these two APIs contained the facilityCode and facilityCodeListProvider...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants