Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heuristic cookie popup detection update makes CMP collector miss some CMP prompts #80

Open
stevenwdv opened this issue Sep 30, 2022 · 3 comments

Comments

@stevenwdv
Copy link

#75 apparently makes the CMP collector miss some CMP prompts.
I tested https://www.oracle.com/java/technologies/javase-downloads.html with optIn with the old & new version and with the old version it does close the CMP prompt while with the latest version it does not. (I have not tested with other pages yet.)

@muodov
Copy link
Member

muodov commented Sep 30, 2022

@stevenwdv thank you for reporting this! It is actually a bug in the autoconsent library, and you're right, optIn does not work after #75.
I will make sure to push a hotfix in that library and update this repo soon.

@kdzwinel
Copy link
Member

kdzwinel commented Mar 1, 2023

@muodov looks like you merged the fix, can we close this?

@muodov
Copy link
Member

muodov commented Mar 1, 2023

@kdzwinel That PR was closed without merge, this one should be fixed by #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants