Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Ignores tags on instance profiles #26

Open
andrewjhumphrey opened this issue Jun 8, 2022 · 1 comment
Open

Bug: Ignores tags on instance profiles #26

andrewjhumphrey opened this issue Jun 8, 2022 · 1 comment

Comments

@andrewjhumphrey
Copy link
Contributor

Also appears to ignore cloudformation suffixes on instance profiles that are lower case.
(see https://buildkite.com/envato-marketplaces/platform-iam-configuration/builds/2315#0181451c-231b-4787-a3f1-7b818181453b) and

aws iam list-instance-profile-tags --instance-profile-name platform-docker-spot-green-InstanceProfile-3YLQsbagLI1q
{
    "Tags": [
        {
            "Key": "iamy-ignore",
            "Value": "true"
        }
    ],
    "IsTruncated": false
}

@orien
Copy link
Member

orien commented Jan 3, 2023

We just hit the instance profile with lower case characters in the suffix.

I see the regex doesn't account for this:

var cfnResourceRegexp = regexp.MustCompile(`-[A-Z0-9]{10,20}$`)

Of course, if it did, it'd match many non-CFN managed resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants