Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics #60

Open
tjayrush opened this issue Oct 11, 2022 · 0 comments
Open

Topics #60

tjayrush opened this issue Oct 11, 2022 · 0 comments

Comments

@tjayrush
Copy link

I understand this is for four-bytes, and I think that's wonderful, but is there something similar for event topics? It would think that it wouldn't be very much more difficult to add that, and it would be just as useful.

One thing to keep in mind, though, is the 'index' keyword. An event can have an identical topic given its name and list of parameter types, but in one case some of the topics are index and in another they are not. Same 32-byte topic, but you have to decode the data differently. The only way I've figured out to handle this case is if the decoding fails without topics, insert them and try again.

Not really an issue, but I wanted to share this. You can close this if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant