Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The LatestVersionProvider should return Promise #509

Closed
idugalic opened this issue Aug 8, 2023 · 2 comments
Closed

The LatestVersionProvider should return Promise #509

idugalic opened this issue Aug 8, 2023 · 2 comments
Assignees
@idugalic
Labels
bug Something isn't working

Comments

@idugalic
Copy link
Member

idugalic commented Aug 8, 2023

The LatestVersionProvider type is currently defined as:

export type LatestVersionProvider<E, V> = (e: E) => V | null;

shouldn't this also return a Promise since it will be doing IO?

Originally posted by @reify-joe-eckard in #508
@idugalic idugalic self-assigned this Aug 8, 2023
@idugalic idugalic added the bug Something isn't working label Aug 8, 2023
@idugalic idugalic changed the title The LatestVersionProvider type is currently defined as: The LatestVersionProvidershould return Promise Aug 8, 2023
idugalic added a commit that referenced this issue Aug 8, 2023
@idugalic
#509 LatestVersionProvider fix - return Promise
a9a6ef8
@idugalic idugalic changed the title The LatestVersionProvidershould return Promise The LatestVersionProvider should return Promise Aug 8, 2023
@idugalic
Copy link
Member Author

idugalic commented Aug 8, 2023

#510

@idugalic idugalic closed this as completed Aug 8, 2023
@idugalic
Copy link
Member Author

#515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idugalic idugalic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@idugalic