Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/statements endpoint includes "voiding statements" #235

Open
Vjedi729 opened this issue May 20, 2022 · 0 comments
Open

/statements endpoint includes "voiding statements" #235

Vjedi729 opened this issue May 20, 2022 · 0 comments

Comments

@Vjedi729
Copy link

When a statement is voided, the xAPI LRS spec states that "A reporting system SHOULD NOT show voided or voiding Statements by default." xAPI-Spec.md at 1.0.2.

While running simple manual tests, I found that this LRS behavior does not match this. Voided statements are excluded, but voiding statements are not.

This is the response I saw from the /statements endpoint, after submitting two statements and then voiding one.

{
    "statements": [
        {
            "actor": {
                "objectType": "Agent",
                "name": "Example Admin",
                "mbox": "mailto:admin@example.com"
            },
            "verb": {
                "id": "http://adlnet.gov/expapi/verbs/voided",
                "display": {
                    "en-US": "voided"
                }
            },
            "object": {
                "objectType": "StatementRef",
                "id": "41f03ec4-0ea6-4f92-b1ca-bdf48d0dcc1f"
            },
            "authority": {
                "objectType": "Agent",
                "account": {
                    "homePage": "http://XXXXXXX",
                    "name": "XXXXX@XXXXXXXXX.XXX"
                }
            },
            "stored": "2022-05-20T13:46:45+00:00",
            "timestamp": "2022-05-20T13:46:45+00:00",
            "id": "e598fbcd-9c7e-4cff-bfa3-9b50ad93aa94"
        },
        {
            "actor": {
                "mbox": "mailto:test.user@example.com",
                "name": "Test User",
                "objectType": "Agent"
            },
            "verb": {
                "id": "http://adlnet.gov/expapi/verbs/launched",
                "display": {
                    "en-US": "launched"
                }
            },
            "object": {
                "objectType": "Activity",
                "id": "http://XXXX,XXXXX...",
                "definition": {
                    "name": {
                        "en-US": "XXXXXXXXXXXXXXXX"
                    },
                    "description": {
                        "en-US": "XXXXXXXXXXXXXX"
                    },
                    "interactionType": "performance"
                }
            },
            "authority": {
                "objectType": "Agent",
                "account": {
                    "homePage": "http://XXXXXXX",
                    "name": "XXXXX@XXXXXXXXX.XXX"
                }
            },
            "stored": "2022-05-19T20:52:14+00:00",
            "timestamp": "2022-05-19T20:52:14+00:00",
            "id": "82a261c6-318f-4675-85b3-c6859ca06c6f"
        }
    ],
    "more": "",
    "totalCount": 2
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant