Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependencies and license checks #1105

Open
franziskuskiefer opened this issue Nov 7, 2024 · 1 comment
Open

Cleanup dependencies and license checks #1105

franziskuskiefer opened this issue Nov 7, 2024 · 1 comment

Comments

@franziskuskiefer
Copy link
Member

After adding license checks in #1035 I reviewed them in #1088. This issue capture the resulting action items.
The licenses themselves are ok. But the checking isn't quite right and there's a dependency that needs to go.

Remove depdencies

Drop proc-macro-error. It is unmaintained. There's an alternative crate (proc-macro-error2) that may be an alternative if needed.

Script does not work

The script to check licenses doesn't work (at least on macos). grep: invalid option -- P.
The resulting bigger problem is that it still print "ok" even when it didn't do anything.

@W95Psp
Copy link
Collaborator

W95Psp commented Nov 12, 2024

Ah, that's the common grep MacOS issues...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants