Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parBuffer smells wrong #23

Open
treeowl opened this issue Jun 1, 2018 · 2 comments
Open

parBuffer smells wrong #23

treeowl opened this issue Jun 1, 2018 · 2 comments

Comments

@treeowl
Copy link
Contributor

treeowl commented Jun 1, 2018

It looks to me as though parBuffer is supposed to spark a limited number of computations at any one time. But as far as I can tell, it actually sparks an unlimited number. In particular, I believe ret (x : xs) (y : ys) should force x.
@simonmar
Copy link
Member

simonmar commented Jun 2, 2018

Looks ok to me. The start function sparks the first N elements, and then as we consume each cons of the result list, ret sparks element N+1, N+2, ... etc.

@treeowl
Copy link
Contributor Author

treeowl commented Jun 2, 2018

Ah, I see! We just need to document that!

@treeowl treeowl mentioned this issue Jun 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonmar @treeowl