Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samuro is missing his trait #101

Open
Asddsa76 opened this issue Feb 10, 2020 · 2 comments
Open

Samuro is missing his trait #101

Asddsa76 opened this issue Feb 10, 2020 · 2 comments

Comments

@Asddsa76
Copy link
Contributor

Samuro.json has no ability for his trait. In its place are the abilities 1 and 2 for selecting clones.
@MGatner
Copy link
Member

MGatner commented Feb 13, 2020

This is an issue upstream with the duplicate removal on heroes-convert: https://github.com/tattersoftware/heroes-convert/blob/0a99eb38fee8841a8f80eb8d73dcfad9187fff47/src/Connect.php#L56

I haven't found a way too love it yet, probably just make an explicit exception. The problem is that both his trait and second heroic have the same nameId "SamuroIllusionMaster".

@MGatner MGatner mentioned this issue Feb 13, 2020
Open
@BenjaBobs
Copy link

BenjaBobs commented Sep 9, 2020 •
edited
Loading

Could do a synthesized uid consisting of both the hotkey and the nameId. I assume the two have different hotkeys, right?
Also I think there might be another issue with Samuro, this image seems to be a lost vikings one: https://github.com/heroespatchnotes/heroes-talents/blob/master/hero/samuro.json#L89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BenjaBobs @MGatner @Asddsa76