Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reactive shutdown orderly #277

Closed
climategadgets opened this issue Aug 29, 2023 · 1 comment
Closed

Make reactive shutdown orderly #277

climategadgets opened this issue Aug 29, 2023 · 1 comment
Labels
$$$ fault tolerance reactive Pertinent to Reactive branches only usability

Comments

@climategadgets
Copy link
Member

climategadgets commented Aug 29, 2023 •
edited
Loading

Expected Behavior

Upon receiving a termination signal, the system shuts down all the peripherals and then exits. Shutdown must be executed in this order:

  1. Disable WebUI and console
  2. Disconnect unit directors so they can't cause mischief
  3. Shut off HVAC devices and economizers
  4. Move dampers to "safe" position
  5. Disconnect collectors
  6. Disconnect connectors
  7. Put switches into "safe" state, if provided
  8. Cancel sensor streams subscriptions
  9. Deactivate MQTT and hardware drivers

Actual Behavior

The system relies on old behavior utilizing Autocloseable with Spring assist which wasn't reliable to begin with, and probably doesn't work at all in reactive branches.

Related Issues

#47
@climategadgets climategadgets added $$$ usability fault tolerance reactive Pertinent to Reactive branches only labels Aug 29, 2023
climategadgets added a commit that referenced this issue Aug 29, 2023
@climategadgets
Removed ad-hoc shutdown hook - need more order (coming (#277)
ebfdd90
climategadgets added a commit that referenced this issue Aug 29, 2023
@climategadgets
Made MQTT adapters reachable for the shutdown hook (#277)
1bb2a8d
climategadgets added a commit that referenced this issue Aug 29, 2023
@climategadgets
Implemented some shutdown handlers (HVAC devices are now off on exit) (…
9dd4417 
…#277)
@climategadgets
Copy link
Member Author

#271 contributed to this; the work is not done completely because there are still missing subsystems in reactive branch, but for the practical purposes it is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$$$ fault tolerance reactive Pertinent to Reactive branches only usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@climategadgets