Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cross-links whose endpoints don't match experimental data #119

Open
benmwebb opened this issue May 27, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@benmwebb
Copy link
Contributor

By design a cross-link in python-ihm acts on the residue pair identified experimentally, but with assigned asyms, i.e. if an ExperimentalCrossLink acts between EntityA-ResidueX and EntityB-ResidueY then every CrossLink which uses that experimental identification must act on AsymC-ResidueX and AsymD-ResidueY where AsymC is an instance of EntityA and AsymD an instance of EntityB. This matches their use in IMP and most other applications. However, some researchers have elected to model cross-links on different residues, e.g. AsymC-ResidueN / AsymD-ResidueM - perhaps because the experimentally-identified residues were not modeled. The dictionary allows for this but python-ihm does not. Add a new class, perhaps NearbyResidueCrossLink, which takes two Residue arguments, and also handle such mismatched cross-links on read.

@benmwebb benmwebb added the enhancement New feature or request label May 27, 2023
@benmwebb benmwebb self-assigned this May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant