Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faster C API for reading loop constructs #29

Open
benmwebb opened this issue Feb 20, 2019 · 0 comments
Open

Add faster C API for reading loop constructs #29

benmwebb opened this issue Feb 20, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@benmwebb
Copy link
Contributor

The C-accelerated mmCIF reader calls a user-provided callback function to process all data in the mmCIF file. For simple categories, this is called once at the end of the file once all keywords for that category have been encountered. For loop constructs, it is called once per line in the loop. This can be quite inefficient since that could be a lot of function calls per loop (which can't be optimized as the function is only known at runtime).

A faster solution would be to have a single callback per loop, and provide an API function to get the next line.

@benmwebb benmwebb added the enhancement New feature or request label Feb 20, 2019
@benmwebb benmwebb self-assigned this Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant