Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use future annotations for same class type #95

Open
dluo96 opened this issue Mar 27, 2023 · 1 comment
Open

feat: use future annotations for same class type #95

dluo96 opened this issue Mar 27, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dluo96
Copy link
Contributor

dluo96 commented Mar 27, 2023

Is your feature request related to a problem? Please describe

This issue is about cleaning the type hinting in the repository. Currently, when a method (inside a given class) returns an object whose type is the class itself (e.g. in Environment), the return type is given with quotes:

class Environment:

    ...

    def unwrapped(self) -> "Environment":
        ...

According to this thread, this is needed for Python<3.7, but can be removed with future annotations from Python 3.7+.

Describe the solution you'd like

Since Jumanji supports Python>=3.8, we could get rid of these quotes throughout the repository and use future annotations instead.

@dluo96 dluo96 added enhancement New feature or request good first issue Good for newcomers labels Mar 27, 2023
@dantp-ai
Copy link
Contributor

dantp-ai commented Jan 5, 2024

I can take this as a first issue :).

@dantp-ai dantp-ai mentioned this issue Jan 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants