Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with XGBoost + binary classification when using TreeExplainer #229

Open
imatiach-msft opened this issue May 8, 2020 · 1 comment
Assignees
Labels
bug Something isn't working high priority High priority (user found only) issues

Comments

@imatiach-msft
Copy link
Collaborator

Describe the bug
User reported issue.
XGBoost + binary classification when using TreeExplainer fails due to bad shape.

SHAP TreeExplainer returns the wrong format for feature contribution values (lightgbm had similar issue but it was already fixed with PR shap/shap#690), we have a disabled test here:

https://github.com/interpretml/interpret-community/blob/master/test/test_explain_model.py#L362

The fix requires a PR to SHAP

To Reproduce
Steps to reproduce the behavior:

  1. Run TreeExplainer on XGBoost binary classifier
  2. See error

Expected behavior
Explanation should be returned

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
Any

Smartphone (please complete the following information):
Any

Additional context
Add any other context about the problem here.

@imatiach-msft imatiach-msft self-assigned this May 8, 2020
@imatiach-msft imatiach-msft added bug Something isn't working high priority High priority (user found only) issues labels May 8, 2020
@imatiach-msft
Copy link
Collaborator Author

imatiach-msft commented May 13, 2020

there was a workaround merged here after a user complaint:
#235
will keep this ticket to track the longer-term fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority High priority (user found only) issues
Development

No branches or pull requests

1 participant