-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NDBC geometry parsing #30
Comments
Just a clarification that at this time it doesn't appear to be certain that a solution will be found with sensorml2iso alone. There are one or two options in the DescribeSensor and GetCapabilities responses that should be explored (while crossing fingers), but it may well be that both are equally plagued by the spatial coordinate errors described in ioos/catalog#69 |
Just copying over info from the IOOS Catalog issue that spawned this one: When I was working on this module originally, I made a list of issues to follow up on (mostly wrt NDBC) after the first Catalog version came out, that at a minimum had a record for every provider's stations.
Here's the code in sensorml2iso that parses lat/lon values: https://github.com/ioos/sensorml2iso/blob/master/sensorml2iso/sensorml2iso.py#L289-L298. There's already some special handling for NDBC since they use a different approach than 52N. But, if I had to guess NDBC's SOS includes some DescribeSensor responses that don't include numbers in the locations we're expecting. Here's an example to show their formatting for most stations:
At the moment, RPS runs a process to generate NDBC's SOS metadata for them. We've reached out to them in the past about running sensorml2iso themselves and managing their own waf, but I don't know if it's on a roadmap for this FY or not. I looked at some examples of the NaN errors in the Harvest Registry, and tracking down the corresponding DescribeSensor request for one, it looks like the position info is encoded in varying ways. We just haven't accommodated for the different possibilities.
So, seems like we either go through and try to find each variation and account for it, or perhaps we can get in contact with someone at NDBC who knows this service well enough to describe the different possibilities. They describe some here: https://sdf.ndbc.noaa.gov/sos/. If anyone wants to tackle any of this, have at it..... I won't be able to get into it for awhile. |
Per ioos/catalog#69: sensorml2iso needs to be updated to properly parse all types of NDBC SOS geometries in DescribeSensor responses.
NDBC SOS documentation: https://sdf.ndbc.noaa.gov/sos/
The text was updated successfully, but these errors were encountered: