From 5f9ad7c3db2f8b7ce61b833340fbb4880b1a69dc Mon Sep 17 00:00:00 2001
From: Sven Strittmatter <sven.strittmatter@iteratec.com>
Date: Wed, 19 Jul 2023 17:49:57 +0200
Subject: [PATCH] larger description for skills

Skills can now hold the size of text. This allow for arbitrary lenghts
see also https://www.postgresql.org/docs/15/datatype-character.html.
This means, the string can be as large as the max length of java String
type that is 2^31-1.

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
---
 .jhipster/Skill.json                             |  4 ++--
 .../20210510110913_added_entity_Skill.xml        |  4 ++--
 ...t_entity_Skill_change_size_of_description.xml | 16 ++++++++++++++++
 src/main/resources/config/liquibase/master.xml   |  1 +
 .../skill/update/skill-update.component.html     |  8 ++++----
 .../skill/update/skill-update.component.ts       |  4 ++--
 teamDojo_v2.jdl                                  |  4 ++--
 7 files changed, 29 insertions(+), 12 deletions(-)
 create mode 100644 src/main/resources/config/liquibase/changelog/20230511163039_edit_entity_Skill_change_size_of_description.xml

diff --git a/.jhipster/Skill.json b/.jhipster/Skill.json
index c316b3b1..9d609c2e 100644
--- a/.jhipster/Skill.json
+++ b/.jhipster/Skill.json
@@ -23,13 +23,13 @@
       "fieldName": "descriptionEN",
       "fieldType": "String",
       "fieldValidateRules": ["maxlength"],
-      "fieldValidateRulesMaxlength": "8192"
+      "fieldValidateRulesMaxlength": "2147483647"
     },
     {
       "fieldName": "descriptionDE",
       "fieldType": "String",
       "fieldValidateRules": ["maxlength"],
-      "fieldValidateRulesMaxlength": "8192"
+      "fieldValidateRulesMaxlength": "2147483647"
     },
     {
       "fieldName": "implementationEN",
diff --git a/src/main/resources/config/liquibase/changelog/20210510110913_added_entity_Skill.xml b/src/main/resources/config/liquibase/changelog/20210510110913_added_entity_Skill.xml
index a961f49f..72c2ae4e 100644
--- a/src/main/resources/config/liquibase/changelog/20210510110913_added_entity_Skill.xml
+++ b/src/main/resources/config/liquibase/changelog/20210510110913_added_entity_Skill.xml
@@ -20,10 +20,10 @@
             <column name="title_de" type="varchar(80)">
                 <constraints nullable="true" />
             </column>
-            <column name="description_en" type="varchar(8192)">
+            <column name="description_en" type="varchar(4096)">
                 <constraints nullable="true" />
             </column>
-            <column name="description_de" type="varchar(8192)">
+            <column name="description_de" type="varchar(4096)">
                 <constraints nullable="true" />
             </column>
             <column name="implementation_en" type="varchar(4096)">
diff --git a/src/main/resources/config/liquibase/changelog/20230511163039_edit_entity_Skill_change_size_of_description.xml b/src/main/resources/config/liquibase/changelog/20230511163039_edit_entity_Skill_change_size_of_description.xml
new file mode 100644
index 00000000..ba99c86f
--- /dev/null
+++ b/src/main/resources/config/liquibase/changelog/20230511163039_edit_entity_Skill_change_size_of_description.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<databaseChangeLog
+    xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+    xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.6.xsd
+                        http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd">
+
+    <!--
+        Change description length
+    -->
+    <changeSet id="20230511163039_1" author="Sven Marquardt">
+        <modifyDataType tableName="skill" columnName="description_de" newDataType="text"/>
+        <modifyDataType tableName="skill" columnName="description_en" newDataType="text"/>
+    </changeSet>
+</databaseChangeLog>
diff --git a/src/main/resources/config/liquibase/master.xml b/src/main/resources/config/liquibase/master.xml
index 4c3642d0..20c7aeba 100644
--- a/src/main/resources/config/liquibase/master.xml
+++ b/src/main/resources/config/liquibase/master.xml
@@ -47,6 +47,7 @@
     <!-- ### MODIFICATION-START ### -->
     <include file="config/liquibase/changelog/20210803214100_added_entity_Image_badge_default.xml" relativeToChangelogFile="false"/>
     <include file="config/liquibase/changelog/20210803214100_added_entity_Image_level_default.xml" relativeToChangelogFile="false"/>
+    <include file="config/liquibase/changelog/20230511163039_edit_entity_Skill_change_size_of_description.xml" relativeToChangelogFile="false"/>
     <include file="config/liquibase/initial_demo_data.xml" relativeToChangelogFile="false"/>
     <!-- ### MODIFICATION-END ### -->
 </databaseChangeLog>
diff --git a/src/main/webapp/app/entities/skill/update/skill-update.component.html b/src/main/webapp/app/entities/skill/update/skill-update.component.html
index 814c1b36..5368d3d4 100644
--- a/src/main/webapp/app/entities/skill/update/skill-update.component.html
+++ b/src/main/webapp/app/entities/skill/update/skill-update.component.html
@@ -92,9 +92,9 @@ <h2 id="jhi-skill-heading" data-cy="SkillCreateUpdateHeading" jhiTranslate="team
               class="form-text text-danger"
               *ngIf="editForm.get('descriptionEN')?.errors?.maxlength"
               jhiTranslate="entity.validation.maxlength"
-              [translateValues]="{ max: 8192 }"
+              [translateValues]="{ max: 2147483647 }"
             >
-              This field cannot be longer than 8192 characters.
+              This field cannot be longer than 2147483647 characters.
             </small>
           </div>
         </div>
@@ -126,9 +126,9 @@ <h2 id="jhi-skill-heading" data-cy="SkillCreateUpdateHeading" jhiTranslate="team
               class="form-text text-danger"
               *ngIf="editForm.get('descriptionDE')?.errors?.maxlength"
               jhiTranslate="entity.validation.maxlength"
-              [translateValues]="{ max: 8192 }"
+              [translateValues]="{ max: 2147483647 }"
             >
-              This field cannot be longer than 8192 characters.
+              This field cannot be longer than 2147483647 characters.
             </small>
           </div>
         </div>
diff --git a/src/main/webapp/app/entities/skill/update/skill-update.component.ts b/src/main/webapp/app/entities/skill/update/skill-update.component.ts
index f474aec0..055b443a 100644
--- a/src/main/webapp/app/entities/skill/update/skill-update.component.ts
+++ b/src/main/webapp/app/entities/skill/update/skill-update.component.ts
@@ -22,8 +22,8 @@ export class SkillUpdateComponent implements OnInit {
     id: [],
     titleEN: [null, [Validators.required, Validators.minLength(5), Validators.maxLength(80)]],
     titleDE: [null, [Validators.minLength(5), Validators.maxLength(80)]],
-    descriptionEN: [null, [Validators.maxLength(8192)]],
-    descriptionDE: [null, [Validators.maxLength(8192)]],
+    descriptionEN: [null, [Validators.maxLength(2147483647)]],
+    descriptionDE: [null, [Validators.maxLength(2147483647)]],
     implementationEN: [null, [Validators.maxLength(4096)]],
     implementationDE: [null, [Validators.maxLength(4096)]],
     validationEN: [null, [Validators.maxLength(4096)]],
diff --git a/teamDojo_v2.jdl b/teamDojo_v2.jdl
index e6cce6e9..b128e588 100644
--- a/teamDojo_v2.jdl
+++ b/teamDojo_v2.jdl
@@ -83,8 +83,8 @@ entity Report {
 entity Skill {
     titleEN String required minlength(5) maxlength(80)
     titleDE String minlength(5) maxlength(80)
-    descriptionEN String maxlength(8192)
-    descriptionDE String maxlength(8192)
+    descriptionEN String maxlength(2147483647)
+    descriptionDE String maxlength(2147483647)
     implementationEN String maxlength(4096)
     implementationDE String maxlength(4096)
     validationEN String maxlength(4096)