Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difference between ImageService save method in V1 and V2 #100

Open
Amar-Bolkan opened this issue May 3, 2022 · 0 comments
Open

Difference between ImageService save method in V1 and V2 #100

Amar-Bolkan opened this issue May 3, 2022 · 0 comments
Assignees
@Weltraumschaf
Labels
backend bug Something isn't working

Comments

@Amar-Bolkan
Copy link
Contributor

When saving the image after editing a team the images small and medium need to be set to null. Otherwise those arent automatically set in the backend.

Reason: In V1 the backend checks wether or not the large image is != null. In V2 the medium and small are checked instead.

Relevant files:

  • src/main/java/de/otto/teamdojo/service/impl/ImageServiceImpl.java Line 60 (V1)
  • src/main/java/com/iteratec/teamdojo/service/impl/custom/ExtendedImageServiceImpl.java Line 65 (V2)
  • src/main/webapp/app/custom/teams/teams-edit/teams-edit.component.ts Line 199 (V2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Weltraumschaf Weltraumschaf

Labels
backend bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Weltraumschaf @Amar-Bolkan @RamiSouai