Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implement Astropy units #26

Open
jgieseler opened this issue Nov 8, 2022 · 0 comments
Open

Fully implement Astropy units #26

jgieseler opened this issue Nov 8, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jgieseler
Copy link
Owner

Adjust code so that Astropy units are used wherever possible. This is already included in recent code changes like the following:

alpha = math.degrees(omega * (radius-target_solar_radius*aconst.R_sun).to(u.km).value / vsw)

But in this example, the solar wind speed vsw is still fixed to km/s. Fully incorporating units would help to avoid possible problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant