-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next steps to package and distribute the kernel #9
Comments
Then we could also check this works well with another xeus kernel such as https://github.com/DerThorsten/xeus-wren (if it can be compiled to wasm) |
It should compile to wasm, it is very simple plain C (this is why I choose this lang.) |
Can you elaborate what you mean with "specify it as a parameter". So |
btw the wren kernel is atm in https://github.com/DerThorsten/jupyterlite_xeus_wren |
If all we need is the name of the path to the wasm file, it could be passed in the instantiation options here: |
The |
unfortunately there is a bit more : the dockerfile is different:
|
Right, the Dockerfiles would also be different and live in their respective repos. |
Before tackling the steps above, we could actually make a first release of That would be a good way to make sure we can use the releaser for that, check all files are correctly bundled (#18 already helps with this) and setup the process for the next releases. @DerThorsten I've added you as owner on https://pypi.org/project/jupyterlite-xeus-lua/ We can use the Jupyter Releaser to publish the extension to PyPI and npm: https://jupyter-releaser.readthedocs.io/en/latest/get_started/making_first_release.html#set-up |
@jtpio I'll try to start with moving the common parts of the jupyterlite xeus kernel to https://github.com/jupyterlite/xeus-kernel |
@jtpio out of curiosity, how would you approach this? |
It would be fine to copy what we have. Also https://github.com/jupyterlite/xeus-kernel will be a JavaScript dependency only so we don't need to copy the Python files. |
@jtpio I have a bit trouble setting the things up st I can import the local xeus-kernel-(base) code from jupyterlite-xeus-lua. I was trying to add the local package to jupyterlite-xeus-lua via
but then the import does not work.
Any suggestion on setting up the dev environment st. I can use xeus-kernel-(base) in the jupyterlute-xeus-lua are appreciated |
Right that is often an issue when developing locally and the package has not been published yet. iirc handling of linked packages was fixed in a newer version of Just to make, is Otherwise a trick is to use a local npm registry like |
@jtpio thanks! indeed the lib was missing (sry for the noob questions) I guess the next tricky part will be having a dynamic import in the xeus base worker =) |
@jtpio https://github.com/jupyterlite/xeus-kernel/tree/experiments this is where the common code is |
Thanks @DerThorsten for starting this! We can go ahead and release Would you mind making me an admin of this repo, and I'll move it to the Thanks! |
@jtpio you already have access to the repo,...cannot find the menue to give you more premissions. |
And I cannot do it "You don’t have the permission to create public repositories on jupyterlite" |
Ah right Admin is probably just for organizations, this repo is under a private account. @DerThorsten I made you owner of the org so you can do the transfer. Thanks! |
done |
Nice, thanks! I'll proceed with a couple of renaming for consistency. Followed by a release. |
Thinking about the next steps once we get the first version working as a federated extension:
xeus-lua
can depend on. This repo would contain most of the logicjupyterlite-xeus-lua
would live in its own repo, for example https://github.com/jupyterlite/xeus-lua-kernel, and would depend on the@jupyterlite/xeus-kernel
packages. It would also have the tools (Dockerfile
) to create the wasm file, and would specify it as a parameter@ts-ignore
in the codeThe text was updated successfully, but these errors were encountered: