Hishel stores no-store data

[douglas-raillard-arm]

Hishel used with AsyncInMemoryStorage() accumulates data in memory, even though the request was done using extensions={'cache_disabled': True} and the response had Cache-Control: no-store set. This leads to an out-of-memory situation in my case as the data is quite large.

[douglas-raillard-arm]

Actually it may not store as such, but maybe hishel is simply not preserving non-cached streaming responses and collects in memory the entire data set, even if it will not be cached. The memory steadily grows during the request, then goes back to a low level after the request is finished.

[karpetrosyan]

Hi!

I think we do not store responses if the cache was disabled using cache_disabled extension.
As you mentioned, hishel reads the response data even when it should not be stored.

Here is where we do it in hishel:

hishel/hishel/_async/_transports.py

Lines 205 to 213 in 5da6012

	await httpcore_regular_response.aread()
	await httpcore_regular_response.aclose()
	if self._controller.is_cachable(request=httpcore_request, response=httpcore_regular_response):
	await self._storage.store(
	key,
	response=httpcore_regular_response,
	request=httpcore_request,
	)

Simply, moving these two lines into the if should resolve the problem