Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate-module returns exit code 1 on successful validation #547

Closed
pandabear opened this issue Dec 19, 2022 · 0 comments · Fixed by #564
Closed

validate-module returns exit code 1 on successful validation #547

pandabear opened this issue Dec 19, 2022 · 0 comments · Fixed by #564
Assignees

Comments

@pandabear
Copy link

Description:

I tried using master-branch built dbptk to validate a siard file on linux environment.

I noticed upon trying siard file validation out that it always returns exit code 1 regardless whether it was invoked to validate a valid or invalid siard file. On shell environment, exit code 1 usually implies that an error has happened while exit code 0 means there is no error.

Steps required to reproduce the bug:

  1. Execute java -jar dbptk-app-2.11.0-SNAPSHOT.jar validate.
  2. Execute echo $?, see how it returns 0.
  3. Check dbptk-app.log.txt and see how the log mentions EXIT CODE: 0.
  4. Execute java -jar dbptk-app-2.11.0-SNAPSHOT.jar validate -if my_valid.siard.
  5. Execute echo $?, see how it returns 1.
  6. Check dbptk-app.log.txt and see how the log mentions EXIT CODE: 1.
@AntonioG70 AntonioG70 linked a pull request Nov 3, 2023 that will close this issue
@AntonioG70 AntonioG70 self-assigned this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants