Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve/ignore extension provided properties #72

Closed
delanym opened this issue May 31, 2021 · 7 comments
Closed

resolve/ignore extension provided properties #72

delanym opened this issue May 31, 2021 · 7 comments

Comments

@delanym
Copy link

delanym commented May 31, 2021

I use this Maven extension to set a property with the value of the git worktree directory, among others.
I also leave the a property <git.dir.worktree>${git.dir.worktree}</git.dir.worktree> in the top-level pom to fail the build if for some reason the extension doesn't run. But this completely breaks IDEA's ability to resolve packages.
pascalgn/properties-maven-extension#59

What's the best approach here?

@krasa
Copy link
Owner

krasa commented May 31, 2021

@krasa
Copy link
Owner

krasa commented May 31, 2021

@delanym
Copy link
Author

delanym commented Feb 8, 2022

@krasa i don't have the option of using a plugin over of an exception. I'm basically asking when will IDEA support this?

@krasa
Copy link
Owner

krasa commented Feb 8, 2022

I am not an IDEA developer :-)

I would suggest not using extensions that require IDE support.

@delanym
Copy link
Author

delanym commented Feb 8, 2022

The extension doesn't require IDE support - the IDE requires support for the extension, but I see your point about this being a mere plugin.

@delanym delanym closed this as completed Feb 8, 2022
@krasa
Copy link
Owner

krasa commented Feb 8, 2022

Funny, I had this problem 10 years ago too https://youtrack.jetbrains.com/issue/IDEA-75122
(Although it is a little different one.)

@delanym
Copy link
Author

delanym commented Feb 8, 2022

I need the extension to set git properties for the build as it does this once for the whole build. If I do that with a git-*-plugin it will query git 500x. Of course I could make that info inheritable, but that rules out using -pl type builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants