Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Enforce login security by permission node? #220

Open
steven-archer opened this issue Nov 26, 2020 · 3 comments
Open

Suggestion: Enforce login security by permission node? #220

steven-archer opened this issue Nov 26, 2020 · 3 comments
Assignees
Milestone

Comments

@steven-archer
Copy link

A great feature that I would like to see is enforcing or bypassing login security using a permission node.

Here's my use-case:

I have a Geyser server (Java + Bedrock server) and I want to make some bedrock players staff on it. I can use Login Security just fine the way it is for that, but I was hoping to make it so that only staff had to log in. I wanted regular players to just be able to join and play without having to register or log in.

I looked through the documentation and didn't see any permission nodes implemented that would do this. I'm picturing something like...

  • loginsecurity.bypass (For players who do not need to log in.)

Most permissions plugins can handle revoking of parent permissions too using -- so:

  • -loginsecurity.bypass (this would remove the bypass for roles like 'staff' which might inherit from another role like 'default')

Of course, I'm no programmer, if it makes more sense to do this the other way around with something like '- loginsecurity.enforce' then that's great too. Either way would accomplish more-or-less the same effect.

I hope you see this as a useful idea, I'm sure it would be useful to a lot of servers, especially bigger ones which don't normally need people to log in, but want that extra layer of security for their staff members.

@Karbzee
Copy link

Karbzee commented Feb 13, 2023

Can we please have this implemented, @lenis0012

@lenis0012
Copy link
Owner

Hi. Thanks for letting me know this issue is still desired. I will see about adding it in the next version.

@lenis0012 lenis0012 added this to the 3.2 milestone Feb 14, 2023
@lenis0012 lenis0012 self-assigned this Feb 14, 2023
@lenis0012 lenis0012 pinned this issue Feb 14, 2023
lenis0012 added a commit that referenced this issue Mar 11, 2023
@lenis0012
Copy link
Owner

lenis0012 commented Mar 11, 2023

This will be implemented in v3.2

Please try the dev build on https://ci.codemc.io/job/lenis0012/job/LoginSecurity/

The permission node is "ls.bypass"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants