From aeed53fd895841082552beec9a136737fb863c13 Mon Sep 17 00:00:00 2001 From: Edward Schults Date: Fri, 1 Sep 2023 10:27:20 +0200 Subject: [PATCH] simplify errors for find or create professor --- lib/edusign/client.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/edusign/client.rb b/lib/edusign/client.rb index 4aa95eb..00160db 100644 --- a/lib/edusign/client.rb +++ b/lib/edusign/client.rb @@ -231,12 +231,11 @@ def create_professor(first_name:, last_name:, email:) def find_or_create_professor(first_name:, last_name:, email:) response = api :get, "/professor/by-email/#{email}" - raise Response::Error, Response::Error::PROFESSOR_NOT_FOUND_ERROR_MESSAGE if response.message == "professor not found" raise Response::Error, Response::Error::PROFESSOR_DELETED_ERROR_MESSAGE if response.result.present? && response.result[:HIDDEN].any? && response.result[:HIDDEN].include?(response.result[:ID]) response.result rescue Response::Error => e - raise e unless [Response::Error::PROFESSOR_NOT_FOUND_ERROR_MESSAGE, Response::Error::PROFESSOR_DELETED_ERROR_MESSAGE].include?(e.message) || e.message.include?(Response::Error::CANNOT_GET_PROFESSOR_BY_EMAIL_ERROR_MESSAGE) + raise e unless [Response::Error::PROFESSOR_DELETED_ERROR_MESSAGE].include?(e.message) || e.message.include?(Response::Error::CANNOT_GET_PROFESSOR_BY_EMAIL_ERROR_MESSAGE) response = create_professor(first_name: first_name, last_name: last_name, email: email) response.result @@ -284,7 +283,6 @@ def options(opts = {}) class Response class Error < StandardError - PROFESSOR_NOT_FOUND_ERROR_MESSAGE = "professor not found".freeze PROFESSOR_DELETED_ERROR_MESSAGE = "professor was deleted".freeze CANNOT_GET_PROFESSOR_BY_EMAIL_ERROR_MESSAGE = "Error - cannot get professor by email".freeze end