DHT Queries don't show the peer executing the query

[umgefahren]

When I query the DHT from a Peer, i.e. looking for a provider, why doesn't the peer querying shows up when it's the one providing?
I guess this is intentional, but how can I fix this from an application perspective?

[mxinden]

After a quick look I don't think we explicitly filter out the local node from the provider set. I might be wrong.

Could you provide a small reproducer, e.g. based on the test below?

rust-libp2p/protocols/kad/src/behaviour/test.rs

Lines 839 to 843 in 25004c4

	/// A node joining a fully connected network via three (ALPHA_VALUE) bootnodes
	/// should be able to add itself as a provider to the X closest nodes of the
	/// network where X is equal to the configured replication factor.
	#[test]
	fn add_provider() {

[umgefahren]

Although this is not my code, the problem can be seen in [examples/distributed-key-value-store.rs].

[umgefahren]

Any updates on this?

[mxinden]

Thanks. I seem to have misunderstood your initial question.

Yes, a get_providers call does not check the local store. A get_record does:

rust-libp2p/protocols/kad/src/behaviour.rs

Lines 673 to 682 in 25004c4

	if let Some(record) = self.store.get(key) {
	if record.is_expired(Instant::now()) {
	self.store.remove(key)
	} else {
	records.push(PeerRecord {
	peer: None,
	record: record.into_owned(),
	});
	}
	}

Do you want to propose a patch, making get_providers check the local store like get_records does today @umgefahren?

[umgefahren]

I can certainly try; however I'm not really familiar with the library. If I make the patch it will take time, as I've already found a botch for my application.