Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to generate simpler appups #14

Open
jwheare opened this issue Jul 10, 2017 · 2 comments
Open

Option to generate simpler appups #14

jwheare opened this issue Jul 10, 2017 · 2 comments

Comments

@jwheare
Copy link

jwheare commented Jul 10, 2017

From #13

The plugin can struggle to generate correct appups when there are complex supervision trees involved.

It might be nice to add the ability to specify a simpler appup generation algorithm for certain deps, where just loading all the modules and restarting the application would work fine.

For example, I encountered auto-generation failing when upgrading between this diff lpgauth/statsderl@v0.3.5...0.5.2

It ended up adding 8 generate_supervisor_child_instruction pairs for each of the dynamically generated children, but using the module name rather than their dynamic names. In this case an application restart would have been better.

In order to enable consistent appups for a dependency during a CI build, this would probably need to be configured in rebar.config somehow, for example:

{appup, [
    {application_restart, [name_of_dep1, name_of_dep2]}
]}.

Or something better.

@lrascao
Copy link
Owner

lrascao commented Jul 10, 2017

Would it work to use the mechanism described in #13 and override the statsderl dependency appup with a custom that does the restart?

@jwheare
Copy link
Author

jwheare commented Jul 10, 2017

Yeah definitely would work that way, just wondering if this might be a common case you want to handle directly. Alternatively, you might be able to detect this sort of supervision tree and improve the automatic generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants