Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model editing support #275

Open
linkerzhang opened this issue May 23, 2019 · 15 comments
Open

Model editing support #275

linkerzhang opened this issue May 23, 2019 · 15 comments

Comments

@linkerzhang
Copy link

Is there any plan to have Netron support model editing please? This will be a very useful feature

@linkerzhang linkerzhang changed the title Netron supports model editing [Feature request] Netron supports model editing May 23, 2019
@mrgloom
Copy link

mrgloom commented May 23, 2019

Is it possible to edit names of input and output layers of onnx model?

@lutzroeder lutzroeder changed the title [Feature request] Netron supports model editing Model editing support May 23, 2019
@linkerzhang
Copy link
Author

There's one more scenario happened frequently is, do some manual constant folding optimization. Say, it's known that a sub-graph can be constant-folded, and user would like to directly remove the sub-graph and replace it with an initializer.

@lutzroeder
Copy link
Owner

lutzroeder commented Jun 5, 2019

@linkerzhang could this be implemented as an ONNX Optimizer?

@vfbsilva
Copy link

@lutzroeder Editing would be great. I really would like to use it for training with yolo and darknet. In fact I found your tool googleing exactly for a way to edit the files with a gui

@minrui-hust
Copy link

does netron support editing now?

@lutzroeder lutzroeder reopened this Oct 10, 2021
@schegde
Copy link

schegde commented Feb 18, 2022

Editing feature in Netron itself would be very cool!! I love the Netron UI for ONNX model inspection and all information is presented in one integrated fashion!

@chausner-audeering
Copy link

Even just basic editing support would be amazing:

  • Include/exclude nodes from the list of input/output nodes
  • Remove nodes

Repository owner deleted a comment Mar 14, 2022
@davids91
Copy link

Since models can be edited through the onnx python API e.g here, it would be a possible way of resolving this to introduce a way to run python script, and then the community could add their own scripts into the editor.

@vjsrinivas
Copy link

This could be helpful for anyone looking for something similar: https://github.com/ZhangGe6/onnx-modifier
It builds on top of Netron.

@weimingzha0
Copy link

Interested in this feature too and like to contribute.
It involves 3 areas:

  1. side-bar attribute view need to be editable
  2. data changed in side-bar be accessiable by model
  3. serialization (protobuf, json, flatbuffer, xml...)

The current protoc.js and protobuf.js only have decoder/reader.
Should we add encoder/writer by ourself? Or should we use existing project like https://github.com/protobufjs/protobuf.js/ ?

@lutzroeder
Copy link
Owner

lutzroeder commented Oct 9, 2022

Should we add encoder/writer by ourself?

Yes, extend the existing libraries instead of adding dependencies.

@weimingzha0
Copy link

I have an initial implementation for protobuf encoding (#995)

@Zireael07
Copy link

Bump! Any news?

@KyotoSunshine
Copy link

bump

@jinguojie-alibaba
Copy link

This work is still active and could be help

https://github.com/ZhangGe6/onnx-modifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

14 participants