Confusing message when empty email value is submitted, should mention "email" not ": This value"

[jerclarke]

Describe the bug

Hi all, it's SO GREAT to see this plugin being actively developed again! I don't know who motivated it, but I was delighted to see there were updates for recent WP, AND fixes for long-running error log notices etc. Thanks so much!

On to my bug: A stakeholder in our org got confused when they clicked the "subscribe" button on the outward facing form, expecting to be taken to the page, and got this error in the form:

: This value should not be blank.

They thought something was broken about the form.

Admittedly, they clicked a submit button on a form with no data, but at the same time, I think this error message is needlessly confusing.

If I submit with an invalid email such as ddd, I get the following error instead:

Email Address: Please fill out a valid email address.

To me this is MUCH clearer, and I think they would have figured it out immediately.

So could we consider a more accurate message? Really, I'd just use the exact same message in both cases. An empty email is an invalid one, so asking them to "Please fill out a valid email address" applies in both scenarios.

Thank you for considering this request 🙏🏻

Steps to Reproduce

• Go to the pulic-facing form
• Click Subscribe without entering an email
• See an error message that could be more clear about the issue

Screenshots, screen recording, code snippet

No response

Environment information

Latest version of plugin

WordPress information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[iamdharmesh]

Thanks for reporting the issue, @jerclarke. A PR has been raised to fix this issue, and it will be included in the upcoming plugin release. Thanks a lot for your contribution to improving this plugin.

[dkotter]

@jerclarke The PR looks good in my testing and I've merged that in now, but if you have some time to test and ensure it works for your situation, that would be great.

[jerclarke]

Right on! Tested the patch and the message looks nice and clear to me 🙏🏻💪🏻🎉