Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form validation errors close the window #2

Open
foobarbecue opened this issue Mar 5, 2019 · 1 comment
Open

Form validation errors close the window #2

foobarbecue opened this issue Mar 5, 2019 · 1 comment

Comments

@foobarbecue
Copy link

Thanks for the great plugin!

One issue I ran into was that if I forgot to fill in the required input in the form and clicked go, I get an error ("No method chosen," "No option chosen" etc.) and then the plugin closes. When I re-open it, the form is blank. It would be nice if instead of closing the form, it would send me back to it with my selections still there.

I would be interested in submitting a PR to make this fix, as my first contribution to the plugin. I probably have time to do it this weekend.
@foobarbecue foobarbecue changed the title Form validation errors shouldn't delete all your input Form validation errors close the window Mar 5, 2019
@mauroalberti
Copy link
Owner

Hi,
sorry for the late replay.
It would be great if you could submit a pull..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foobarbecue @mauroalberti