Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regularizing large-scale features only? #27

Open
megbedell opened this issue Oct 9, 2018 · 4 comments
Open

regularizing large-scale features only? #27

megbedell opened this issue Oct 9, 2018 · 4 comments

Comments

@megbedell
Copy link
Owner

Maybe in addition to doing regularization, we want to put a prior on the flux variance over large wavelength scales or something along those lines?

In orders where the telluric features are strong, the regularization validation scheme naturally prefers very weak L2 amplitude, but this can lead to weird large-scale issues:
o63_final
o63_final
(plots are order 63 for a G star (top) and an M star (bottom))

Similarly, I think sometimes continuum issues that really should be absorbed into the observatory rest-frame component (i.e. the tellurics) are going into the star because the star's regularization is weaker to capture its actual absorption features:
o33_final

Can we decouple the regularization on every point (to get rid of noise in the case of no spectral features) from the expectation that the continuum should be flat over long scales (at least for
the star)?

@davidwhogg
Copy link
Collaborator

This is a great question; we might need some help / advice...

@davidwhogg
Copy link
Collaborator

...but for now we should either live with it or increase L1...?

@dfm
Copy link
Collaborator

dfm commented Oct 9, 2018

The "regularization" that we would want to handle this is called a Gaussian Process, of course :-)

I'd say that this is probably an issue for another time, but I do have an implementation of celerite in tf so it wouldn't be too hard to incorporate in principle...

@megbedell
Copy link
Owner Author

ah ok, maybe a little bit down the line we want to build a GP component into the model and let it handle all continuum fitting (including the initial normalization which we're not really happy with)?

@megbedell megbedell added this to the run on all of HARPS milestone Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants