Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need a new config/secrets system #372

Open
classabbyamp opened this issue Mar 22, 2021 · 2 comments
Open

We need a new config/secrets system #372

classabbyamp opened this issue Mar 22, 2021 · 2 comments
Labels
enhancement New feature or request investigate This issue needs investigation priority-med This issue should be worked on when possible

Comments

@classabbyamp
Copy link
Member

No description provided.

@classabbyamp classabbyamp added the old/question Further information is requested label Mar 22, 2021
@classabbyamp
Copy link
Member Author

possible idea: have some wrapper around options.py that ensures the values exist, and if not, automatically falls back to the template/default, but it's invisible to the code (i.e. not .get())

@0x5c 0x5c added enhancement New feature or request investigate This issue needs investigation priority-med This issue should be worked on when possible and removed old/question Further information is requested labels Mar 22, 2021
@0x5c 0x5c changed the title add a way to automatically add new configuration values to data/options.py when upgrading the bot? We need a new config/secrets system Mar 22, 2021
@0x5c 0x5c mentioned this issue Mar 22, 2021
Merged
8 tasks
@classabbyamp
Copy link
Member Author

classabbyamp commented Apr 24, 2021 •
edited
Loading

did some research on this, looks like there is no library out there now that fits our needs. I'd recommend we build something that's pydantic/yaml/json-based. maybe make it a library or something @0x5c

lincolnloop/goodconf might be a good inspiration for some parts (pydantic, generating default config files, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request investigate This issue needs investigation priority-med This issue should be worked on when possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@classabbyamp @0x5c