Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP's XML functions for generating the XML. #24

Open
mibe opened this issue Sep 17, 2014 · 0 comments
Open

Use PHP's XML functions for generating the XML. #24

mibe opened this issue Sep 17, 2014 · 0 comments
Labels

Comments

@mibe
Copy link
Owner

mibe commented Sep 17, 2014

I think it is time to replace the internal methods makeHeader(), makeChannels(), makeItems(), makeFooter() and makeNode() with PHP's own functions to generate the XML output. The current methods have some quirks like the two described in #23 and #18 (last comment).

There are plenty of function & classes to choose from. SimpleXML, XMLWriter or even the full DOM classes look promising. However, these classes are / were extensions and not always available on every PHP installation. This depends heavily on the server configuration. And that's the advantage of having the XML assembled in own methods: It's very unlikely that plain string functions are deactivated. 😉

@mibe mibe added the feature label Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant