New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very small bug in QuadEncoder constructor? #15

Open

joepasquariello opened this issue Feb 24, 2023 · 1 comment

joepasquariello commented Feb 24, 2023

Lines 83-86 of constructor are shown below. Should the 2nd "if" statement be testing PhaseB_pin?

  if(PhaseA_pin != 255 )
	enc_xbara_mapping(PhaseA_pin, PHASEA, pin_pus);
  if(PhaseA_pin != 255 )
	enc_xbara_mapping(PhaseB_pin, PHASEB, pin_pus);

The text was updated successfully, but these errors were encountered:

Owner

mjs513 commented Mar 11, 2023 •

edited

Loading

Hi Joe
Sorry for the long delay but the answer is yes i will update now.

UPDATE: Just pushed the fix

mjs513 added a commit that referenced this issue


          Fix per Issue #15

f3bc677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment