Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaConsumerConfig and KafkaProducerConfig apply helpers do not properly set properties #287

Open
tfreiling opened this issue Jul 16, 2021 · 1 comment

Comments

@tfreiling
Copy link

tfreiling commented Jul 16, 2021

When you set KafkaConsumerConfig(source= someTypesafeConfig) you would expect that the configs that are not explicitly set by monix KafkaConsumerConfig would get passed onto properties, but that is not the case as it is being set to properties = Map.empty:
https://github.com/monix/monix-kafka/blob/master/kafka-0.11.x/src/main/scala/monix/kafka/KafkaConsumerConfig.scala#L439
Similarly with KafkaProducerConfig.

@paualarco
Copy link
Member

Hi @tfreiling-livongo,

Thanks for raising the issue, I think this could be worth implementing, though it would be an enhancement since the properties can always be overwritten from the config class.

The purpose of the properties config is to provide extra properties that are not captured by the config class , however most of the common used ones are already explicitly defined. Could tell what extra properties were you trying to add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants