-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please look into adding sponge placeholder api #227
Comments
Do you think I should fork that outdated repository? Why me? I am not the developer of that resource, but the one who created it. The reason I don't add PAPI to this plugin as a dependency is already outdated, not updated (3rd year), API availability is probably broken, and there may be issues that can't be fixed in another resource. Or maybe it's not updated because it's not needed? This is conceivable for a smaller project, but for the source code, it is somewhat necessary to add code fixes and additional implementations. Anyway, why don't you fork that repository instead of me? I have different things to do and need to break time with other projects. Also, this is duplicates with #162 |
I don’t see any placeholder context in sponge that knows all placeholders, Sponge can only provide placeholder context for resources to implement placeholders properly. The Sponge API has only |
If you can support nucleus placeholders it would be amazing. They use sponge placeholder system not the old PAPI, more info here: https://v2.nucleuspowered.org/docs/links-and-tokens.html |
Same again, Nucleus also uses its own placeholders, not supposed for other resources. |
Isn't really possible to support Nucleous placeholders? Support for their AFK placeholder token would be amazing. It says here it's possible (https://v2.nucleuspowered.org/docs/links-and-tokens.html), in the "Using Tokens in Other Plugins" part. They seem to use it here: https://github.com/CodeCrafter47/BungeeTabListPlus/blob/4e5468a12b3dcfc4f84e018562f79834d8fd6b62/bungee/src/main/java/codecrafter47/bungeetablistplus/placeholder/PlayerPlaceholderResolver.java#L147 |
It’s only possible if we use the available API, but if that happened, there would be a few million afk resources besides Nucleus that would have to be added as dependencies again. We don’t want to add 200 resources as dependencies. But in general, it’s worth adding resources that are popular and used by many people. |
Nucleus fit perfectly in that phrase "popular and used by many" 👍 |
Description
Suggest looking into sponge's placeholder api, will probably be better to use that to get placeholders to work on tablist. Because it makes it hard for people to add external placeholders to use the plugin, or to create a fork for the plugin. don't have to use placeholderAPI sponge has added there own placeholderapi.
The text was updated successfully, but these errors were encountered: