Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please look into adding sponge placeholder api #227

Open
MrWhiteFlamesYT opened this issue Apr 21, 2021 · 8 comments
Open

Please look into adding sponge placeholder api #227

MrWhiteFlamesYT opened this issue Apr 21, 2021 · 8 comments
Labels
Other: Duplicate Platform: Sponge This issue is sponge related Status: Help wanted Help needed from other users to find the source of the issue Type: New feature

Comments

@MrWhiteFlamesYT
Copy link

MrWhiteFlamesYT commented Apr 21, 2021

Description

Suggest looking into sponge's placeholder api, will probably be better to use that to get placeholders to work on tablist. Because it makes it hard for people to add external placeholders to use the plugin, or to create a fork for the plugin. don't have to use placeholderAPI sponge has added there own placeholderapi.

@montlikadani
Copy link
Owner

Do you think I should fork that outdated repository? Why me? I am not the developer of that resource, but the one who created it. The reason I don't add PAPI to this plugin as a dependency is already outdated, not updated (3rd year), API availability is probably broken, and there may be issues that can't be fixed in another resource. Or maybe it's not updated because it's not needed? This is conceivable for a smaller project, but for the source code, it is somewhat necessary to add code fixes and additional implementations. Anyway, why don't you fork that repository instead of me? I have different things to do and need to break time with other projects.

Also, this is duplicates with #162

@montlikadani montlikadani added Other: Duplicate Platform: Sponge This issue is sponge related labels Apr 21, 2021
@MrWhiteFlamesYT
Copy link
Author

A little bit rude are we, I am not revering to the papi you are talking about,
image
I am talking about this where the support team on discord told me to tell you about this to see if you can implement it to the plugin it will support the other plugins placeholder without depending on another plugin to do it. and unlike you that have coding experience, is it hard for me that can't do coding so i am frustrated cause of it, i hate myself cause of my self confidence that struggles to learn the coding languages, Struggling to understand the stuff to a point so don't just blubber words without knowing if the user can code or not, don't blabber words out that does not go to the point i am making and i did see that papi was last updated in 2017 for sponge but sponge brought out there own embedded to there api.

@montlikadani
Copy link
Owner

I don’t see any placeholder context in sponge that knows all placeholders, Sponge can only provide placeholder context for resources to implement placeholders properly. The Sponge API has only PlaceholderContext, PlaceholderParser, and other classes that allow you to parse placeholders for other resources as well if you create some. The only way, though, is just creating dependency with the PlaceholderAPI, since I haven’t seen any plugins that use the contexts mentioned above, each resource uses only its own, like the TabList. I don’t know who and why said this that Sponge’s built-in system can provide placeholders for other plugins, at least I haven’t seen it.

@kanagawawave
Copy link

I don’t see any placeholder context in sponge that knows all placeholders, Sponge can only provide placeholder context for resources to implement placeholders properly. The Sponge API has only PlaceholderContext, PlaceholderParser, and other classes that allow you to parse placeholders for other resources as well if you create some. The only way, though, is just creating dependency with the PlaceholderAPI, since I haven’t seen any plugins that use the contexts mentioned above, each resource uses only its own, like the TabList. I don’t know who and why said this that Sponge’s built-in system can provide placeholders for other plugins, at least I haven’t seen it.

If you can support nucleus placeholders it would be amazing. They use sponge placeholder system not the old PAPI, more info here: https://v2.nucleuspowered.org/docs/links-and-tokens.html

@montlikadani
Copy link
Owner

montlikadani commented Jul 8, 2021

Same again, Nucleus also uses its own placeholders, not supposed for other resources.

@montlikadani montlikadani added the Status: Help wanted Help needed from other users to find the source of the issue label Jul 12, 2021
@rubataka
Copy link

Same again, Nucleus also uses its own placeholders, not supposed for other resources.

Isn't really possible to support Nucleous placeholders? Support for their AFK placeholder token would be amazing. It says here it's possible (https://v2.nucleuspowered.org/docs/links-and-tokens.html), in the "Using Tokens in Other Plugins" part. They seem to use it here: https://github.com/CodeCrafter47/BungeeTabListPlus/blob/4e5468a12b3dcfc4f84e018562f79834d8fd6b62/bungee/src/main/java/codecrafter47/bungeetablistplus/placeholder/PlayerPlaceholderResolver.java#L147

@montlikadani
Copy link
Owner

It’s only possible if we use the available API, but if that happened, there would be a few million afk resources besides Nucleus that would have to be added as dependencies again. We don’t want to add 200 resources as dependencies. But in general, it’s worth adding resources that are popular and used by many people.

@kanagawawave
Copy link

It’s only possible if we use the available API, but if that happened, there would be a few million afk resources besides Nucleus that would have to be added as dependencies again. We don’t want to add 200 resources as dependencies. But in general, it’s worth adding resources that are popular and used by many people.

Nucleus fit perfectly in that phrase "popular and used by many" 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other: Duplicate Platform: Sponge This issue is sponge related Status: Help wanted Help needed from other users to find the source of the issue Type: New feature
Projects
None yet
Development

No branches or pull requests

4 participants