Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onPresenterDestroy() lifecycle hook #43

Open
aasitnikov opened this issue Sep 10, 2019 · 0 comments
Open

Add onPresenterDestroy() lifecycle hook #43

aasitnikov opened this issue Sep 10, 2019 · 0 comments
Assignees
@aasitnikov
Labels
enhancement New feature or request

Comments

@aasitnikov
Copy link
Member

In MvpFragment there is complex logic to decide whether getMvpDelegate().onDestroy() should be called.

Consider adding some lifecycle method to notify extending class when getMvpDelegate().onDestroy() was called. It can be used to close DI or some other scope, which has lifespan same as presenter.
@aasitnikov aasitnikov added the enhancement New feature or request label Sep 10, 2019
@aasitnikov aasitnikov self-assigned this Sep 10, 2019
@aasitnikov aasitnikov changed the title Add onMvpDestroy() lifecycle hook Add onPresenterDestroy() lifecycle hook Sep 10, 2019
@aasitnikov aasitnikov mentioned this issue Sep 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aasitnikov aasitnikov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aasitnikov